Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 603523002: Allow all app windows to minimize. (Closed)

Created:
6 years, 3 months ago by jackhou1
Modified:
6 years, 3 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, James Cook, kuscher1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow all app windows to minimize. On CrOS, app windows can already be minimized by clicking their icon in the taskbar. This just makes them show a minimize button as well. On Windows, we prevent minimize if the window can't maximize, which doesn't really make sense. They will now be able to minimize and show a minimize button. On Mac and Linux they could always minimize. BUG=351179 Committed: https://crrev.com/7eb02c28e1859fff329ad68d2e5970315366b28f Cr-Commit-Position: refs/heads/master@{#296437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/native_app_window/native_app_window_views.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
pkotwicz, could you take a look since you have context from the earlier CL (https://codereview.chromium.org/553333007/)
6 years, 3 months ago (2014-09-24 11:19:25 UTC) #2
pkotwicz
LGTM
6 years, 3 months ago (2014-09-24 13:43:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603523002/1
6 years, 3 months ago (2014-09-24 16:35:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b2ed6af7a14ce33bcc381a3b0f5b8a04340b1180
6 years, 3 months ago (2014-09-24 16:41:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 16:41:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eb02c28e1859fff329ad68d2e5970315366b28f
Cr-Commit-Position: refs/heads/master@{#296437}

Powered by Google App Engine
This is Rietveld 408576698