Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: components/native_app_window/native_app_window_views.cc

Issue 603523002: Allow all app windows to minimize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/native_app_window/native_app_window_views.h" 5 #include "components/native_app_window/native_app_window_views.h"
6 6
7 #include "base/threading/sequenced_worker_pool.h" 7 #include "base/threading/sequenced_worker_pool.h"
8 #include "content/public/browser/render_view_host.h" 8 #include "content/public/browser/render_view_host.h"
9 #include "content/public/browser/render_widget_host_view.h" 9 #include "content/public/browser/render_widget_host_view.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 return resizable_ && !size_constraints_.HasFixedSize() && 212 return resizable_ && !size_constraints_.HasFixedSize() &&
213 !WidgetHasHitTestMask(); 213 !WidgetHasHitTestMask();
214 } 214 }
215 215
216 bool NativeAppWindowViews::CanMaximize() const { 216 bool NativeAppWindowViews::CanMaximize() const {
217 return resizable_ && !size_constraints_.HasMaximumSize() && 217 return resizable_ && !size_constraints_.HasMaximumSize() &&
218 !app_window_->window_type_is_panel() && !WidgetHasHitTestMask(); 218 !app_window_->window_type_is_panel() && !WidgetHasHitTestMask();
219 } 219 }
220 220
221 bool NativeAppWindowViews::CanMinimize() const { 221 bool NativeAppWindowViews::CanMinimize() const {
222 // TODO(jackhou): Change this to always be true. 222 return true;
223 return CanMaximize();
224 } 223 }
225 224
226 base::string16 NativeAppWindowViews::GetWindowTitle() const { 225 base::string16 NativeAppWindowViews::GetWindowTitle() const {
227 return app_window_->GetTitle(); 226 return app_window_->GetTitle();
228 } 227 }
229 228
230 bool NativeAppWindowViews::ShouldShowWindowTitle() const { 229 bool NativeAppWindowViews::ShouldShowWindowTitle() const {
231 return app_window_->window_type() == AppWindow::WINDOW_TYPE_V1_PANEL; 230 return app_window_->window_type() == AppWindow::WINDOW_TYPE_V1_PANEL;
232 } 231 }
233 232
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 438
440 bool NativeAppWindowViews::CanHaveAlphaEnabled() const { 439 bool NativeAppWindowViews::CanHaveAlphaEnabled() const {
441 return widget_->IsTranslucentWindowOpacitySupported(); 440 return widget_->IsTranslucentWindowOpacitySupported();
442 } 441 }
443 442
444 void NativeAppWindowViews::SetVisibleOnAllWorkspaces(bool always_visible) { 443 void NativeAppWindowViews::SetVisibleOnAllWorkspaces(bool always_visible) {
445 widget_->SetVisibleOnAllWorkspaces(always_visible); 444 widget_->SetVisibleOnAllWorkspaces(always_visible);
446 } 445 }
447 446
448 } // namespace native_app_window 447 } // namespace native_app_window
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698