Issue 603253003: Revert of Restored disable print preview policy.

Issue 603253003: Revert of Restored disable print preview policy. (Closed)

Created:
6 years, 2 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 2 months ago

Reviewers:
Lei Zhang, Joao da Silva, pastarmovj

CC:
chromium-reviews, joaodasilva+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Restored disable print preview policy. (patchset #8 id:140001 of https://codereview.chromium.org/597933002/) Reason for revert: Noticed a bug in render_view_context_menu.cc change Original issue's description: > Restored disable print preview policy. > Not exact revert of https://codereview.chromium.org/488853002 > > BUG=374321, 416396 > > Committed: https://crrev.com/15daa893f50daebf33ccf06ba67d74788700e495 > Cr-Commit-Position: refs/heads/master@{#296751} TBR=thestig@chromium.org,joaodasilva@chromium.org,pastarmovj@chromium.org NOTREECHECKS=true NOTRY=true BUG=374321, 416396 Committed: https://crrev.com/cc742a2cfb257466f0afd6abbfad8cb11dd72f78 Cr-Commit-Position: refs/heads/master@{#296831}

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -65 lines)			Patch
M	build/common.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_handler_list_factory.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/prefs/command_line_pref_store.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_context_menu/render_view_context_menu.cc	View	1 chunk	+20 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	2 chunks	+7 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	components/policy/resources/policy_templates.json	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Vitaly Buka (NO REVIEWS)

Created Revert of Restored disable print preview policy.

6 years, 2 months ago (2014-09-25 23:35:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603253003/1

6 years, 2 months ago (2014-09-25 23:36:43 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 4f89e33c2ad7bb5adf09bcf52e4437c6f72dd29a

6 years, 2 months ago (2014-09-25 23:38:11 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 23:39:10 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cc742a2cfb257466f0afd6abbfad8cb11dd72f78
Cr-Commit-Position: refs/heads/master@{#296831}