Removed --disable-print-preview switch and policy.

Removed --disable-print-preview switch and policy.
Also removed dependent switches --disable-scripted-print-throttling and --renderer-print-preview.

BUG=374321
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291251

[Lei Zhang, 2014-08-19 23:59:23]

Can you check with the policy folks and make sure this page gets updated
properly for M39? http://www.chromium.org/administrators/policy-list-3

[Lei Zhang, 2014-08-20 00:01:15]

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/chrome_co...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/chrome_co...
chrome/browser/chrome_content_browser_client.cc:1280:
command_line->AppendSwitch(switches::kRendererPrintPreview);
You should get rid of switches::kRendererPrintPreview as well, and assume it's
always there on the renderer side.

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/printing/...
File chrome/browser/printing/print_preview_test.cc (right):

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/printing/...
chrome/browser/printing/print_preview_test.cc:7: #include
"base/prefs/pref_service.h"
Remove. Also pref_names.h below.

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (left):

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1503:
print_view_manager->PrintNow();
Is PrintNow() dead code?

[Vitaly Buka (NO REVIEWS), 2014-08-20 01:16:14]

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/chrome_co...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/chrome_co...
chrome/browser/chrome_content_browser_client.cc:1280:
command_line->AppendSwitch(switches::kRendererPrintPreview);
On 2014/08/20 00:01:15, Lei Zhang wrote:
> You should get rid of switches::kRendererPrintPreview as well, and assume it's
> always there on the renderer side.

Done.

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/printing/...
File chrome/browser/printing/print_preview_test.cc (right):

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/printing/...
chrome/browser/printing/print_preview_test.cc:7: #include
"base/prefs/pref_service.h"
On 2014/08/20 00:01:15, Lei Zhang wrote:
> Remove. Also pref_names.h below.

Done.

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (left):

https://codereview.chromium.org/488853002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1503:
print_view_manager->PrintNow();
On 2014/08/20 00:01:15, Lei Zhang wrote:
> Is PrintNow() dead code?

Done.

[Lei Zhang, 2014-08-20 01:22:28]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-08-20 01:49:38]

On 2014/08/20 01:22:28, Lei Zhang wrote:
> lgtm

Actually PrintNow is used for AppleScript and for !ENABLE_FULL_PRINTING

[Lei Zhang, 2014-08-20 01:52:13]

On 2014/08/20 01:49:38, Vitaly Buka wrote:
> On 2014/08/20 01:22:28, Lei Zhang wrote:
> > lgtm
> 
> Actually PrintNow is used for AppleScript and for !ENABLE_FULL_PRINTING

Maybe we can switch AppleScript to print preview and only keep PrintNow() for
!ENABLE_FULL_PRINTING ?

[Vitaly Buka (NO REVIEWS), 2014-08-20 02:02:21]

On 2014/08/20 01:52:13, Lei Zhang wrote:
> On 2014/08/20 01:49:38, Vitaly Buka wrote:
> > On 2014/08/20 01:22:28, Lei Zhang wrote:
> > > lgtm
> > 
> > Actually PrintNow is used for AppleScript and for !ENABLE_FULL_PRINTING
> 
> Maybe we can switch AppleScript to print preview and only keep PrintNow() for
> !ENABLE_FULL_PRINTING ?

done

[Vitaly Buka (NO REVIEWS), 2014-08-20 02:02:27]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-20 02:02:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/488853002/100001

[Vitaly Buka (NO REVIEWS), 2014-08-20 02:06:50]

+tsepez for chrome/common/print_messages.h

[commit-bot: I haz the power, 2014-08-20 03:32:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 03:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 03:35:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Thiemo Nagel, 2014-08-20 08:31:17]

On 2014/08/19 23:59:23, Lei Zhang wrote:
> Can you check with the policy folks and make sure this page gets updated
> properly for M39? http://www.chromium.org/administrators/policy-list-3

Could you please update components/policy/resources/policy_templates.json as
part of this CL?  I'll make sure that
http://www.chromium.org/administrators/policy-list-3 is re-generated once the
change has landed.

[Tom Sepez, 2014-08-20 16:43:27]

rubberstamp LGTM on deleting messages.

[Vitaly Buka (NO REVIEWS), 2014-08-21 01:24:07]

+bartfab for policy_templates.json

[bartfab (slow), 2014-08-21 09:09:43]

configuration_policy_handler_list_factory.cc and policy_templates.json LGTM with
nit.

https://codereview.chromium.org/488853002/diff/120001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/488853002/diff/120001/components/policy/resou...
components/policy/resources/policy_templates.json:3695: 'deprecated': True,
Please add a line to the policy description that states this policy is
deprecated and will no longer be honored as of M39.

[Vitaly Buka (NO REVIEWS), 2014-08-21 09:57:41]

https://codereview.chromium.org/488853002/diff/120001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/488853002/diff/120001/components/policy/resou...
components/policy/resources/policy_templates.json:3695: 'deprecated': True,
On 2014/08/21 09:09:43, bartfab wrote:
> Please add a line to the policy description that states this policy is
> deprecated and will no longer be honored as of M39.

Done.

[Vitaly Buka (NO REVIEWS), 2014-08-21 17:49:07]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-21 17:51:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/488853002/180001

[commit-bot: I haz the power, 2014-08-21 18:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 18:56:51]

Failed to apply patch for chrome/browser/chrome_content_browser_client.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chrome_content_browser_client.cc
  Hunk #2 FAILED at 1338.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chrome_content_browser_client.cc.rej

Patch:       chrome/browser/chrome_content_browser_client.cc
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc
b/chrome/browser/chrome_content_browser_client.cc
index
74dcec82f17f3fbd19ac14f48e1ac7223ad63764..c1f3a8ee7234f8f8cb88ce3419e355581e22d3c8
100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1277,9 +1277,6 @@ void
ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
             switches::kDisableClientSidePhishingDetection);
       }
 
-      if (!prefs->GetBoolean(prefs::kPrintPreviewDisabled))
-        command_line->AppendSwitch(switches::kRendererPrintPreview);
-
       InstantService* instant_service =
           InstantServiceFactory::GetForProfile(profile);
       if (instant_service &&
@@ -1341,7 +1338,6 @@ void
ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
       switches::kCloudPrintURL,
       switches::kCloudPrintXmppEndpoint,
       switches::kDisableBundledPpapiFlash,
-      switches::kDisableScriptedPrintThrottling,
       switches::kEnableAppView,
       switches::kEnableAppWindowControls,
       switches::kEnableBenchmarking,

[Vitaly Buka (NO REVIEWS), 2014-08-21 19:08:19]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-21 19:09:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/488853002/180001

[commit-bot: I haz the power, 2014-08-21 19:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 19:12:03]

Failed to apply patch for chrome/browser/chrome_content_browser_client.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chrome_content_browser_client.cc
  Hunk #2 FAILED at 1338.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chrome_content_browser_client.cc.rej

Patch:       chrome/browser/chrome_content_browser_client.cc
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc
b/chrome/browser/chrome_content_browser_client.cc
index
74dcec82f17f3fbd19ac14f48e1ac7223ad63764..c1f3a8ee7234f8f8cb88ce3419e355581e22d3c8
100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1277,9 +1277,6 @@ void
ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
             switches::kDisableClientSidePhishingDetection);
       }
 
-      if (!prefs->GetBoolean(prefs::kPrintPreviewDisabled))
-        command_line->AppendSwitch(switches::kRendererPrintPreview);
-
       InstantService* instant_service =
           InstantServiceFactory::GetForProfile(profile);
       if (instant_service &&
@@ -1341,7 +1338,6 @@ void
ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
       switches::kCloudPrintURL,
       switches::kCloudPrintXmppEndpoint,
       switches::kDisableBundledPpapiFlash,
-      switches::kDisableScriptedPrintThrottling,
       switches::kEnableAppView,
       switches::kEnableAppWindowControls,
       switches::kEnableBenchmarking,

[Vitaly Buka (NO REVIEWS), 2014-08-21 19:13:39]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-21 19:15:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/488853002/200001

[commit-bot: I haz the power, 2014-08-21 23:56:47]

Committed patchset #9 (200001) as 291251