Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: Source/core/html/HTMLAppletElement.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased upto r183571 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLAppletElement.cpp
diff --git a/Source/core/html/HTMLAppletElement.cpp b/Source/core/html/HTMLAppletElement.cpp
index eb955365b27074cb447797d1c29c64c09352641a..53ed03d7854ae554de0b4f3745d15a0f79bbd137 100644
--- a/Source/core/html/HTMLAppletElement.cpp
+++ b/Source/core/html/HTMLAppletElement.cpp
@@ -183,8 +183,8 @@ void HTMLAppletElement::updateWidgetInternal()
paramValues.append(param->value());
}
- OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder;
- RefPtr<Widget> widget;
+ OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder = nullptr;
+ RefPtrWillBeRawPtr<Widget> widget = nullptr;
if (frame->loader().allowPlugins(AboutToInstantiatePlugin)) {
placeholder = frame->loader().client()->createPluginPlaceholder(document(), KURL(), paramNames, paramValues, m_serviceType, false);
if (!placeholder)

Powered by Google App Engine
This is Rietveld 408576698