Move the Widget hierarchy to the Oilpan heap.

Source/core/html/HTMLPlugInElement.cpp

Index: Source/core/html/HTMLPlugInElement.cpp
diff --git a/Source/core/html/HTMLPlugInElement.cpp b/Source/core/html/HTMLPlugInElement.cpp
index 768e48db98c386a5de2cf91d45bd3ec72fe0ac9b..3711e4f39f61ef592c27c268467b0dd1f9da39a3 100644
--- a/Source/core/html/HTMLPlugInElement.cpp
+++ b/Source/core/html/HTMLPlugInElement.cpp
@@ -87,9 +87,46 @@ void HTMLPlugInElement::trace(Visitor* visitor)
 {
     visitor->trace(m_imageLoader);
     visitor->trace(m_placeholder);
+    visitor->trace(m_persistedPluginWidget);
     HTMLFrameOwnerElement::trace(visitor);
 }
 
+#if ENABLE(OILPAN)
+void HTMLPlugInElement::disconnectContentFrame()
+{
+    if (m_persistedPluginWidget) {
+        m_persistedPluginWidget->dispose();
+        m_persistedPluginWidget = nullptr;
+    }
+    HTMLFrameOwnerElement::disconnectContentFrame();
+}
+
+void HTMLPlugInElement::shouldDisposePlugin()
+{
+    if (m_persistedPluginWidget && m_persistedPluginWidget->isPluginView())
+        toPluginView(m_persistedPluginWidget.get())->shouldDisposePlugin();
+}
+#endif
+
+void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget)
+{
+#if ENABLE(OILPAN)
+    if (m_persistedPluginWidget && m_persistedPluginWidget != widget) {
+        if (m_persistedPluginWidget->isPluginView()) {
+            if (LocalFrame* frame = toPluginView(m_persistedPluginWidget.get())->pluginFrame()) {

[haraken, 2014/10/11 17:33:02]

Can we add ASSERT(frame) instead of having an if branch?

[sof, 2014/10/12 08:16:22]

Done.

+                frame->unregisterPluginElement(this);
+            }
+        }
+    }
+    if (widget && widget->isPluginView()) {
+        if (LocalFrame* frame = toPluginView(widget)->pluginFrame()) {

[haraken, 2014/10/11 17:33:02]

Ditto.

[sof, 2014/10/12 08:16:22]

Done.

+            frame->registerPluginElement(this);
+        }
+    }
+#endif
+    m_persistedPluginWidget = widget;
+}
+
 bool HTMLPlugInElement::canProcessDrag() const
 {
     return pluginWidget() && pluginWidget()->isPluginView() && toPluginView(pluginWidget())->canProcessDrag();
@@ -202,13 +239,10 @@ void HTMLPlugInElement::detach(const AttachContext& context)
     // Only try to persist a plugin widget we actually own.
     Widget* plugin = ownedWidget();
     if (plugin && plugin->pluginShouldPersist())
-        m_persistedPluginWidget = plugin;
-#if ENABLE(OILPAN)
-    else if (plugin)
-        plugin->detach();
-#endif
+        setPersistedPluginWidget(plugin);
+
     resetInstance();
-    // FIXME - is this next line necessary?
+    // Clear the widget; will trigger disposal of it with Oilpan.
     setWidget(nullptr);
 
     if (m_isCapturingMouseEvents) {
@@ -336,7 +370,7 @@ void HTMLPlugInElement::defaultEventHandler(Event* event)
         if (toRenderEmbeddedObject(r)->showsUnavailablePluginIndicator())
             return;
     }
-    RefPtr<Widget> widget = toRenderPart(r)->widget();
+    RefPtrWillBeRawPtr<Widget> widget = toRenderPart(r)->widget();
     if (!widget)
         return;
     widget->handleEvent(event);
@@ -479,8 +513,8 @@ bool HTMLPlugInElement::loadPlugin(const KURL& url, const String& mimeType, cons
     WTF_LOG(Plugins, "   Loaded URL: %s", url.string().utf8().data());
     m_loadedUrl = url;
 
-    OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder;
-    RefPtr<Widget> widget = m_persistedPluginWidget;
+    OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder = nullptr;
+    RefPtrWillBeRawPtr<Widget> widget = m_persistedPluginWidget;
     if (!widget) {
         bool loadManually = document().isPluginDocument() && !document().containsPlugins();
         placeholder = frame->loader().client()->createPluginPlaceholder(document(), url, paramNames, paramValues, mimeType, loadManually);
@@ -504,9 +538,9 @@ bool HTMLPlugInElement::loadPlugin(const KURL& url, const String& mimeType, cons
 
     if (renderer) {
         setWidget(widget);
-        m_persistedPluginWidget = nullptr;
+        setPersistedPluginWidget(nullptr);
     } else if (widget != m_persistedPluginWidget) {

[haraken, 2014/10/11 17:33:02]

The 'widget != m_persistedPluginWidget' check won't be needed since it's checked
in setPersistedPluginWidget.

[sof, 2014/10/12 08:16:22]

Not quite, but I've now made setPersistendPluginWidget() do so.

-        m_persistedPluginWidget = widget;
+        setPersistedPluginWidget(widget.get());
     }
     setPlaceholder(nullptr);
     document().setContainsPlugins();