Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: Source/web/PopupMenuChromium.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase upto and resolve r182737 conflict. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/PopupMenuChromium.cpp
diff --git a/Source/web/PopupMenuChromium.cpp b/Source/web/PopupMenuChromium.cpp
index 053e716d3572d27b36f9dfddafd539f269f46039..5464f24750b0423cae1877649f1fbc9903ceb488 100644
--- a/Source/web/PopupMenuChromium.cpp
+++ b/Source/web/PopupMenuChromium.cpp
@@ -47,10 +47,19 @@ PopupMenuChromium::PopupMenuChromium(LocalFrame& frame, PopupMenuClient* client)
PopupMenuChromium::~PopupMenuChromium()
{
+#if !ENABLE(OILPAN)
// When the PopupMenuChromium is destroyed, the client could already have been deleted.
if (m_popup)
m_popup->disconnectClient();
hide();
haraken 2014/09/26 09:19:25 Help me understand: Where are disconnectClient and
sof 2014/09/28 17:03:52 Thanks, I didn't follow through on this dtor chang
+#endif
+}
+
+void PopupMenuChromium::trace(Visitor* visitor)
+{
+ visitor->trace(m_frameView);
+ visitor->trace(m_popup);
+ PopupMenu::trace(visitor);
}
void PopupMenuChromium::show(const FloatQuad& controlPosition, const IntSize& controlSize, int index)

Powered by Google App Engine
This is Rietveld 408576698