Source/web/PopupMenuTest.cpp - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupMenuTest.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase upto and resolve r182737 conflict. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PopupMenuTest.cpp

diff --git a/Source/web/PopupMenuTest.cpp b/Source/web/PopupMenuTest.cpp

index 3b82ddfb49eada90c3bc81598e4fed69192c3126..ee09cb4624b0d90e5f5095733d86d08212d94575 100644

--- a/Source/web/PopupMenuTest.cpp

+++ b/Source/web/PopupMenuTest.cpp

@@ -126,7 +126,7 @@ public:

virtual FontSelector* fontSelector() const { return 0; }

virtual HostWindow* hostWindow() const { return 0; }

- virtual PassRefPtr<Scrollbar> createScrollbar(ScrollableArea*, ScrollbarOrientation, ScrollbarControlSize) { return nullptr; }

+ virtual PassRefPtrWillBeRawPtr<Scrollbar> createScrollbar(ScrollableArea*, ScrollbarOrientation, ScrollbarControlSize) { return nullptr; }

void setDisabledIndex(unsigned index) { m_disabledIndexSet.insert(index); }

void setFocusedNode(Node* node) { m_node = node; }