Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: Source/core/html/HTMLFrameOwnerElement.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase needed again Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFrameOwnerElement.h
diff --git a/Source/core/html/HTMLFrameOwnerElement.h b/Source/core/html/HTMLFrameOwnerElement.h
index b357720863943b9515d90e68ce5832fe0789d5cb..58e2097fb25384bfd745dee405c4299e34b4b86b 100644
--- a/Source/core/html/HTMLFrameOwnerElement.h
+++ b/Source/core/html/HTMLFrameOwnerElement.h
@@ -48,7 +48,7 @@ public:
void setContentFrame(Frame&);
void clearContentFrame();
- void disconnectContentFrame();
+ virtual void disconnectContentFrame();
// Most subclasses use RenderPart (either RenderEmbeddedObject or RenderIFrame)
// except for HTMLObjectElement and HTMLEmbedElement which may return any
@@ -65,7 +65,7 @@ public:
virtual void renderFallbackContent() { }
virtual bool isObjectElement() const { return false; }
- void setWidget(PassRefPtr<Widget>);
+ void setWidget(PassRefPtrWillBeRawPtr<Widget>);
Widget* ownedWidget() const;
class UpdateSuspendScope {
@@ -95,7 +95,7 @@ private:
virtual void dispatchLoad() override;
RawPtrWillBeMember<Frame> m_contentFrame;
- RefPtr<Widget> m_widget;
+ RefPtrWillBeMember<Widget> m_widget;
SandboxFlags m_sandboxFlags;
};

Powered by Google App Engine
This is Rietveld 408576698