Source/core/html/HTMLAppletElement.cpp - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAppletElement.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase needed again Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLAppletElement.cpp

diff --git a/Source/core/html/HTMLAppletElement.cpp b/Source/core/html/HTMLAppletElement.cpp

index 089e12a92276af1bc5dc97a780738d96f7b7164f..8a3d235e46ce74ae215ab9e849108e6140977b56 100644

--- a/Source/core/html/HTMLAppletElement.cpp

+++ b/Source/core/html/HTMLAppletElement.cpp

@@ -182,7 +182,7 @@ void HTMLAppletElement::updateWidgetInternal()

paramValues.append(param->value());

}

- RefPtr<Widget> widget;

+ RefPtrWillBeRawPtr<Widget> widget = nullptr;

if (frame->loader().allowPlugins(AboutToInstantiatePlugin))

widget = frame->loader().client()->createJavaAppletWidget(this, baseURL, paramNames, paramValues);