Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/core/frame/RemoteFrameView.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/RemoteFrameView.h
diff --git a/Source/core/frame/RemoteFrameView.h b/Source/core/frame/RemoteFrameView.h
index 804738a43b58cb1551f4b60fc9b97b90bd7a4073..b4f344e55a7e8a107151642b958b64a99674d913 100644
--- a/Source/core/frame/RemoteFrameView.h
+++ b/Source/core/frame/RemoteFrameView.h
@@ -13,9 +13,9 @@ namespace blink {
class RemoteFrame;
-class RemoteFrameView : public Widget {
+class RemoteFrameView final : public Widget {
public:
- static PassRefPtr<RemoteFrameView> create(RemoteFrame*);
+ static PassRefPtrWillBeRawPtr<RemoteFrameView> create(RemoteFrame*);
virtual ~RemoteFrameView();
@@ -34,13 +34,16 @@ public:
virtual void setFrameRect(const IntRect&) override;
+ virtual void trace(Visitor*) override;
+
private:
explicit RemoteFrameView(RemoteFrame*);
- // The RefPtrWillBePersistent-cycle between RemoteFrame and its RemoteFrameView
- // is broken in the same manner as FrameView::m_frame and LocalFrame::m_view is.
- // See the FrameView::m_frame comment.
- RefPtrWillBePersistent<RemoteFrame> m_remoteFrame;
+ // The properties and handling of the cycle between RemoteFrame
+ // and its RemoteFrameView corresponds to that between LocalFrame
+ // and FrameView. Please see the FrameView::m_frame comment for
+ // details.
+ RefPtrWillBeMember<RemoteFrame> m_remoteFrame;
};
DEFINE_TYPE_CASTS(RemoteFrameView, Widget, widget, widget->isRemoteFrameView(), widget.isRemoteFrameView());

Powered by Google App Engine
This is Rietveld 408576698