Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: Source/core/frame/RemoteFrame.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/RemoteFrame.cpp
diff --git a/Source/core/frame/RemoteFrame.cpp b/Source/core/frame/RemoteFrame.cpp
index b7129e2f0c48dd68581137ed2b712105ea220f2d..462db56955865e8d4f034b7a052624b369480ffb 100644
--- a/Source/core/frame/RemoteFrame.cpp
+++ b/Source/core/frame/RemoteFrame.cpp
@@ -43,14 +43,22 @@ void RemoteFrame::detach()
m_host = nullptr;
}
-void RemoteFrame::setView(PassRefPtr<RemoteFrameView> view)
+void RemoteFrame::trace(Visitor* visitor)
{
+ visitor->trace(m_view);
+ Frame::trace(visitor);
+}
+
+void RemoteFrame::setView(PassRefPtrWillBeRawPtr<RemoteFrameView> view)
+{
+ // Oilpan: as RemoteFrameView performs no finalization actions,
+ // no explicit dispose() of it needed here. (cf. FrameView::dispose().)
m_view = view;
}
void RemoteFrame::createView()
{
- RefPtr<RemoteFrameView> view = RemoteFrameView::create(this);
+ RefPtrWillBeRawPtr<RemoteFrameView> view = RemoteFrameView::create(this);
setView(view);
if (ownerRenderer()) {

Powered by Google App Engine
This is Rietveld 408576698