build/toolchain/win/BUILD.gn - Issue 603143002: gn: Fix more build issues on Win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 603143002: gn: Fix more build issues on Win (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows sdk dir Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index 3e8cd35058fc5eec7056c071e5110bac195f9590..b6497385cb4986792fad0cda036dbbf403c8e740 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -71,7 +71,7 @@ template("msvc_toolchain") {

}

tool("asm") {

- command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} {{include_dirs}} /c /Fo {{output}} {{source}}"

+ command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} {{include_dirs}} /safeseh /c /Fo {{output}} {{source}}"

ckocagil 2014/09/25 20:51:06 I put the /safeseh here but ideally this should be

brettw 2014/09/29 16:45:24 Looks like it. I filed https://code.google.com/p/c

ckocagil 2014/09/29 21:47:09 Done.

description = "ASM {{output}}"

outputs = [

"{{source_out_dir}}/{{target_output_name}}.{{source_name_part}}.obj",