gn: Fix more build issues on Win

build/toolchain/win/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/win/visual_studio_version.gni")
 import("//build/toolchain/goma.gni")
 
 # Should only be running on Windows.
 assert(is_win)
 
@@ skipping 53 matching lines @@
 
     tool("rc") {
       command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{include_dirs}} /fo{{output}} {{source}}"
       outputs = [
         "{{source_out_dir}}/{{target_output_name}}.{{source_name_part}}.res",
       ]
       description = "RC {{output}}"
     }
 
     tool("asm") {
-      command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} {{include_dirs}} /c /Fo {{output}} {{source}}"
+      command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} {{include_dirs}} /safeseh /c /Fo {{output}} {{source}}"

[ckocagil, 2014/09/25 20:51:06]

I put the /safeseh here but ideally this should be parametrized like cflags.
Does that require changes to gn itself?

[brettw, 2014/09/29 16:45:24]

Looks like it. I filed
https://code.google.com/p/chromium/issues/detail?id=418613
for this. I think your change is correct for now, I'm not sure we'll ever need
more than this so adding the flags variable might be a waste of time. Can you
reference that bug in a comment here?

[ckocagil, 2014/09/29 21:47:09]

Done.

       description = "ASM {{output}}"
       outputs = [
         "{{source_out_dir}}/{{target_output_name}}.{{source_name_part}}.obj",
       ]
     }
 
     tool("alink") {
       rspfile = "{{output}}.rsp"
       command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nologo /ignore:4221 /OUT:{{output}} @$rspfile"
       description = "LIB {{output}}"
@@ skipping 80 matching lines @@
 msvc_toolchain("32") {
   environment = "environment.x86"
   cpu_arch = "x64"
 }
 
 msvc_toolchain("64") {
   environment = "environment.x64"
   cpu_arch = "x64"
   force_win64 = true
 }