Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 603113002: Add myself to CC in merge_to_branch.py (Closed)

Created:
6 years, 2 months ago by ulan
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add myself to CC in merge_to_branch.py BUG= R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24222

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/push-to-trunk/git_recipes.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
6 years, 2 months ago (2014-09-25 09:44:00 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/merge_to_branch.py File tools/push-to-trunk/merge_to_branch.py (right): https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/merge_to_branch.py#newcode297 tools/push-to-trunk/merge_to_branch.py:297: options.cc = "ulan@chromium.org" you could try to be smart ...
6 years, 2 months ago (2014-09-25 09:48:33 UTC) #4
ulan
On 2014/09/25 09:48:33, jochen (slow for reviews) wrote: > https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/merge_to_branch.py > File tools/push-to-trunk/merge_to_branch.py (right): > ...
6 years, 2 months ago (2014-09-25 09:57:36 UTC) #5
Michael Achenbach
lgtm
6 years, 2 months ago (2014-09-25 11:20:53 UTC) #6
Michael Achenbach
https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/common_includes.py#newcode673 tools/push-to-trunk/common_includes.py:673: options.bypass_upload_hooks = False Not sure why the tests passed. ...
6 years, 2 months ago (2014-09-25 11:25:24 UTC) #7
ulan
6 years, 2 months ago (2014-09-25 11:28:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24222 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698