| OLD | NEW |
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # Copyright 2013 the V8 project authors. All rights reserved. | 2 # Copyright 2013 the V8 project authors. All rights reserved. |
| 3 # Redistribution and use in source and binary forms, with or without | 3 # Redistribution and use in source and binary forms, with or without |
| 4 # modification, are permitted provided that the following conditions are | 4 # modification, are permitted provided that the following conditions are |
| 5 # met: | 5 # met: |
| 6 # | 6 # |
| 7 # * Redistributions of source code must retain the above copyright | 7 # * Redistributions of source code must retain the above copyright |
| 8 # notice, this list of conditions and the following disclaimer. | 8 # notice, this list of conditions and the following disclaimer. |
| 9 # * Redistributions in binary form must reproduce the above | 9 # * Redistributions in binary form must reproduce the above |
| 10 # copyright notice, this list of conditions and the following | 10 # copyright notice, this list of conditions and the following |
| (...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 539 | 539 |
| 540 def RunStep(self): | 540 def RunStep(self): |
| 541 if self._options.reviewer: | 541 if self._options.reviewer: |
| 542 print "Using account %s for review." % self._options.reviewer | 542 print "Using account %s for review." % self._options.reviewer |
| 543 reviewer = self._options.reviewer | 543 reviewer = self._options.reviewer |
| 544 else: | 544 else: |
| 545 print "Please enter the email address of a V8 reviewer for your patch: ", | 545 print "Please enter the email address of a V8 reviewer for your patch: ", |
| 546 self.DieNoManualMode("A reviewer must be specified in forced mode.") | 546 self.DieNoManualMode("A reviewer must be specified in forced mode.") |
| 547 reviewer = self.ReadLine() | 547 reviewer = self.ReadLine() |
| 548 self.GitUpload(reviewer, self._options.author, self._options.force_upload, | 548 self.GitUpload(reviewer, self._options.author, self._options.force_upload, |
| 549 bypass_hooks=self._options.bypass_upload_hooks) | 549 bypass_hooks=self._options.bypass_upload_hooks, |
| 550 cc=self._options.cc) |
| 550 | 551 |
| 551 | 552 |
| 552 class DetermineV8Sheriff(Step): | 553 class DetermineV8Sheriff(Step): |
| 553 MESSAGE = "Determine the V8 sheriff for code review." | 554 MESSAGE = "Determine the V8 sheriff for code review." |
| 554 | 555 |
| 555 def RunStep(self): | 556 def RunStep(self): |
| 556 self["sheriff"] = None | 557 self["sheriff"] = None |
| 557 if not self._options.sheriff: # pragma: no cover | 558 if not self._options.sheriff: # pragma: no cover |
| 558 return | 559 return |
| 559 | 560 |
| (...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 696 for (number, step_class) in enumerate(step_classes): | 697 for (number, step_class) in enumerate(step_classes): |
| 697 steps.append(MakeStep(step_class, number, self._state, self._config, | 698 steps.append(MakeStep(step_class, number, self._state, self._config, |
| 698 options, self._side_effect_handler)) | 699 options, self._side_effect_handler)) |
| 699 for step in steps[options.step:]: | 700 for step in steps[options.step:]: |
| 700 if step.Run(): | 701 if step.Run(): |
| 701 return 0 | 702 return 0 |
| 702 return 0 | 703 return 0 |
| 703 | 704 |
| 704 def Run(self, args=None): | 705 def Run(self, args=None): |
| 705 return self.RunSteps(self._Steps(), args) | 706 return self.RunSteps(self._Steps(), args) |
| OLD | NEW |