Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 6031015: Fix the "opt-win" build on Visual Studio 10.0 (Closed)

Created:
9 years, 11 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the "opt-win" build on Visual Studio 10.0 Before the change, linking fails with: LINK : fatal error LNK1117: syntax error in option 'PDBPATH:none' "/PDBALTPATH:%_PDB%" works on both MSVC 9.0 and 10.0 and has the same effect of omitting the absolute pathname from the executable. Both before and after, we get: $ strings scons-out/opt-win-x86-32/staging/ncdecode_table.exe | grep -i pdb ncdecode_table.pdb BUG=http://code.google.com/p/nativeclient/issues/detail?id=1287 TEST=build with Windows SDK + trybots Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/native_client/site_scons/site_tools/target_platform_windows.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
I got the fix from https://jira.secondlife.com/browse/SNOW-728?
9 years, 11 months ago (2011-01-05 21:32:51 UTC) #1
Mark Seaborn
On 2011/01/05 21:32:51, Mark Seaborn wrote: > I got the fix from https://jira.secondlife.com/browse/SNOW-728? Oops. Wrong ...
9 years, 11 months ago (2011-01-05 21:34:11 UTC) #2
bradn
9 years, 11 months ago (2011-01-05 21:36:08 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698