Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 6029003: Update TSan to rev 2939 (Closed)

Created:
8 years, 9 months ago by Timur Iskhodzhanov
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update TSan to rev 2939 TEST=TSan bots should remain green TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M binaries/linux_x64/bin/valgrind-tsan.sh View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind-tsan.sh View Binary file 0 comments Download
M binaries/mac/bin/valgrind-tsan.sh View Binary file 0 comments Download
M scripts/build-tsan-for-chromium.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
8 years, 9 months ago (2010-12-20 13:58:23 UTC) #1
Alexander Potapenko
8 years, 9 months ago (2010-12-21 13:58:37 UTC) #2
LGTM

On Mon, Dec 20, 2010 at 4:58 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Update TSan to rev 2939
> TEST=TSan bots should remain green
> TBR=glider
>
> Please review this at http://codereview.chromium.org/6029003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     binaries/linux_x64/bin/valgrind-tsan.sh
>  M     binaries/linux_x86/bin/valgrind-tsan.sh
>  M     binaries/mac/bin/valgrind-tsan.sh
>  M     scripts/build-tsan-for-chromium.sh
>
>
> Index: binaries/linux_x64/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: scripts/build-tsan-for-chromium.sh
> ===================================================================
> --- scripts/build-tsan-for-chromium.sh  (revision 69704)
> +++ scripts/build-tsan-for-chromium.sh  (working copy)
> @@ -70,7 +70,7 @@
>   # }}}
>  }
>
> -TSAN_REV=2528
> +TSAN_REV=2939
>  TSAN_DIR="$VG_SRC_DIR/tsan" # Directory to checkout TSan sources
>  rm -rf "$TSAN_DIR"
>  svn co -r "$TSAN_REV" http://data-race-test.googlecode.com/svn/trunk
> "$TSAN_DIR"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698