Issue 6029003: Update TSan to rev 2939

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6029003: Update TSan to rev 2939 (Closed)

Created:
10 years ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/

Visibility:
Public.

Description

Update TSan to rev 2939 TEST=TSan bots should remain green TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69705

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -1 line)			Patch
M	binaries/linux_x64/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	binaries/linux_x86/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	binaries/mac/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	scripts/build-tsan-for-chromium.sh	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years ago (2010-12-21 13:58:37 UTC) #2

LGTM

On Mon, Dec 20, 2010 at 4:58 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Update TSan to rev 2939
> TEST=TSan bots should remain green
> TBR=glider
>
> Please review this at http://codereview.chromium.org/6029003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     binaries/linux_x64/bin/valgrind-tsan.sh
>  M     binaries/linux_x86/bin/valgrind-tsan.sh
>  M     binaries/mac/bin/valgrind-tsan.sh
>  M     scripts/build-tsan-for-chromium.sh
>
>
> Index: binaries/linux_x64/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/mac/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: scripts/build-tsan-for-chromium.sh
> ===================================================================
> --- scripts/build-tsan-for-chromium.sh  (revision 69704)
> +++ scripts/build-tsan-for-chromium.sh  (working copy)
> @@ -70,7 +70,7 @@
>   # }}}
>  }
>
> -TSAN_REV=2528
> +TSAN_REV=2939
>  TSAN_DIR="$VG_SRC_DIR/tsan" # Directory to checkout TSan sources
>  rm -rf "$TSAN_DIR"
>  svn co -r "$TSAN_REV" http://data-race-test.googlecode.com/svn/trunk
> "$TSAN_DIR"
>
>
>

Expand Messages | Collapse Messages