Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 602793002: Revert "Make logic for disabling OS crash catcher on OSX match comment." (Closed)

Created:
6 years, 2 months ago by erikchen
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Andre, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac: Revert "Make logic for disabling OS crash catcher on OSX match comment." This CL breaks chrome://inducebrowsercrashforrealz I don't know exactly why the behavior is broken, but it appears that setting a signal handler for SIGTRAP interferes with breakpad exception handling. See bug for more details. Original CL: https://codereview.chromium.org/329423003 Original Commit: d81d222cb0d4d83436e1723f697951deaf68fdfa TBR=cpu@chromium.org BUG=402337 Committed: https://crrev.com/bf330448d462fd6fd9199ad2a7b33080974c88ba Cr-Commit-Position: refs/heads/master@{#296530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
erikchen
rsesek: Please review. The CL in question is also likely responsible for https://code.google.com/p/chromium/issues/detail?id=407549, although I ...
6 years, 2 months ago (2014-09-24 17:38:23 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-09-24 17:39:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602793002/1
6 years, 2 months ago (2014-09-24 17:40:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13199)
6 years, 2 months ago (2014-09-24 17:51:10 UTC) #7
Nick Bray (chromium)
LGTM as the original commiter, will try to round up OWNERS.
6 years, 2 months ago (2014-09-24 21:09:40 UTC) #9
Robert Sesek
Reverts can be TBR'd.
6 years, 2 months ago (2014-09-24 21:10:13 UTC) #10
Nick Bray (chromium)
Pushing it through, TBR cpu.
6 years, 2 months ago (2014-09-24 21:13:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602793002/1
6 years, 2 months ago (2014-09-24 21:14:32 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as fe0ca84044d2c743a86c5614c960d42e09cf7b24
6 years, 2 months ago (2014-09-24 21:47:27 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 21:48:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf330448d462fd6fd9199ad2a7b33080974c88ba
Cr-Commit-Position: refs/heads/master@{#296530}

Powered by Google App Engine
This is Rietveld 408576698