Make logic for disabling OS crash catcher on OSX match comment.

Make logic for disabling OS crash catcher on OSX match comment.

As written, the code would only disable the OS crash reporter if
breakpad was not enabled, which is the opposite of the documented
behavior.

This change results in us calling base::mac::DisableOSCrashDumps() for
all processes where base::mac::IsBackgroundOnlyProcess() is true,
including NaCl processes. Before this change, the OS crash reporter
was triggered when NaCl processes crashed in untrusted code, which
would could take 40+ seconds to complete.

BUG=318501
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276928

[Nick Bray (chromium), 2014-06-11 23:39:49]

Please give this CL a little extra scrutiny.  I am assuming the comment is
correct and the implementation is wrong, but I am not an expert on OSX or
breakpad.  In any case, this logic was causing problems for NaCl.

[jochen (gone - plz use gerrit), 2014-06-12 14:37:04]

+rsesek

[Robert Sesek, 2014-06-12 21:26:27]

LGTM

[jochen (gone - plz use gerrit), 2014-06-12 21:27:47]

On 2014/06/12 21:26:27, rsesek wrote:
> LGTM

rs lgtm

[Mark Seaborn, 2014-06-12 21:32:14]

In the commit message, can you explicitly say how this is addressing
https://code.google.com/p/chromium/issues/detail?id=318501 please?

i.e. After this change, we are now calling base::mac::DisableOSCrashDumps() for
all NaCl processes (for which base::mac::IsBackgroundOnlyProcess() is true). 
Before this change, the OS crash reporter was getting triggered when NaCl
processes crash.

[Nick Bray (chromium), 2014-06-12 21:54:38]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2014-06-12 21:57:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ncbray@chromium.org/329423003/20001

[commit-bot: I haz the power, 2014-06-13 05:00:13]

Change committed as 276928