Devtools: make DOM traversal utilities climb shadow tree.

Devtools: make DOM traversal utilities climb shadow tree.

BUG=417275
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183616

[pfeldman, 2014-09-24 16:10:33]

pfeldman@chromium.org changed reviewers:
+ sergeyv@chromium.org

[aandrey, 2014-09-25 05:47:21]

aandrey@chromium.org changed reviewers:
+ aandrey@chromium.org

[aandrey, 2014-09-25 05:47:22]

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ui/DOMExtension.js (right):

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/DOMExtension.js:346:
Node.prototype.parentElementOrShadowHost = function()
I'd expect this to give identical result as parentNodeOrShadowHost() in a DOM
tree containing only Element nodes. Right now it's not the case, might be a bug
here.

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/DOMExtension.js:353: if (node.nodeType ===
Node.DOCUMENT_FRAGMENT_NODE)
else if

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/DOMExtension.js:354: return /** @type {!Element} */
(node.host);
this.host? (see message above)

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/treeoutline.js:337: * @param {?Event} event
either {!Event} or check for null before accessing

[pfeldman, 2014-10-13 13:33:12]

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ui/DOMExtension.js (right):

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/DOMExtension.js:346:
Node.prototype.parentElementOrShadowHost = function()
I think it will produce identical results for DOM trees containing only Element
nodes.

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/DOMExtension.js:353: if (node.nodeType ===
Node.DOCUMENT_FRAGMENT_NODE)
We can't do else if by the guidelines.

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/DOMExtension.js:354: return /** @type {!Element} */
(node.host);
this.host is null for shadow root element children.

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/602783002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/treeoutline.js:337: * @param {?Event} event
On 2014/09/25 05:47:21, aandrey wrote:
> either {!Event} or check for null before accessing

Done.

[apavlov, 2014-10-13 15:10:08]

apavlov@chromium.org changed reviewers:
+ apavlov@chromium.org

[apavlov, 2014-10-13 15:10:09]

lgtm

https://codereview.chromium.org/602783002/diff/50001/Source/devtools/front_en...
File Source/devtools/front_end/elements/ElementsPanel.js (right):

https://codereview.chromium.org/602783002/diff/50001/Source/devtools/front_en...
Source/devtools/front_end/elements/ElementsPanel.js:54:
this.contentElement.classList.add("outline-disclosure", "source-code");
We could add these in the createChild() call just above

[pfeldman, 2014-10-13 15:44:43]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-10-13 15:44:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602783002/50001

[commit-bot: I haz the power, 2014-10-13 16:52:50]

Committed patchset #3 (id:50001) as 183616