Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: Source/devtools/front_end/elements/ElementsPanel.js

Issue 602783002: Devtools: make DOM traversal utilities climb shadow tree. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments addressed. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/layers/LayerTreeOutline.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/Source/devtools/front_end/elements/ElementsPanel.js b/Source/devtools/front_end/elements/ElementsPanel.js
index dfd905c2bc7977c367c3e5e8cfe457915e83985d..c5dc5804d5645150a498d4a93483d29ed291315f 100644
--- a/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/Source/devtools/front_end/elements/ElementsPanel.js
@@ -51,8 +51,7 @@ WebInspector.ElementsPanel = function()
this.contentElement = stackElement.createChild("div");
this.contentElement.id = "elements-content";
- this.contentElement.classList.add("outline-disclosure");
- this.contentElement.classList.add("source-code");
+ this.contentElement.classList.add("outline-disclosure", "source-code");
apavlov 2014/10/13 15:10:09 We could add these in the createChild() call just
if (!WebInspector.settings.domWordWrap.get())
this.contentElement.classList.add("nowrap");
WebInspector.settings.domWordWrap.addChangeListener(this._domWordWrapSettingChanged.bind(this));
@@ -692,7 +691,7 @@ WebInspector.ElementsPanel.prototype = {
_mouseMovedInCrumbs: function(event)
{
- var nodeUnderMouse = document.elementFromPoint(event.pageX, event.pageY);
+ var nodeUnderMouse = event.elementFromPoint();
var crumbElement = nodeUnderMouse.enclosingNodeOrSelfWithClass("crumb");
var node = /** @type {?WebInspector.DOMNode} */ (crumbElement ? crumbElement.representedObject : null);
if (node)
@@ -701,7 +700,7 @@ WebInspector.ElementsPanel.prototype = {
_mouseMovedOutOfCrumbs: function(event)
{
- var nodeUnderMouse = document.elementFromPoint(event.pageX, event.pageY);
+ var nodeUnderMouse = event.elementFromPoint();
if (nodeUnderMouse && nodeUnderMouse.isDescendant(this.crumbsElement))
return;
« no previous file with comments | « no previous file | Source/devtools/front_end/layers/LayerTreeOutline.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698