Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 602773003: Eliminate special keyed load string stub in favor of uniform handlers. (Closed)

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Eliminate special keyed load string stub in favor of uniform handlers. KeyedLoadIC installs a special case if the receiver is a string. Although there are several maps for strings, in practice we seem to be able to treat them individually because a given KeyedLoad site only sees 1-2 string types. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24661

Patch Set 1 #

Patch Set 2 : REBASE and ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -201 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 6 chunks +37 lines, -21 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 chunks +41 lines, -8 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/ic/ic.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/ic/ic.cc View 1 4 chunks +14 lines, -23 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Yang here is the string handler cl. * Some assembly code just had to ...
6 years, 2 months ago (2014-09-26 12:46:12 UTC) #2
Yang
On 2014/09/26 12:46:12, mvstanton wrote: > Hi Yang here is the string handler cl. > ...
6 years, 2 months ago (2014-09-30 13:32:34 UTC) #3
mvstanton
Thanks Yang, here are the ports, all the best, --Michael
6 years, 2 months ago (2014-10-01 13:22:48 UTC) #4
Yang
On 2014/10/01 13:22:48, mvstanton wrote: > Thanks Yang, here are the ports, all the best, ...
6 years, 2 months ago (2014-10-08 13:43:50 UTC) #5
mvstanton
6 years, 2 months ago (2014-10-16 11:43:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698