src/ic/ic-compiler.cc - Issue 602773003: Eliminate special keyed load string stub in favor of uniform handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic-compiler.cc

Issue 602773003: Eliminate special keyed load string stub in favor of uniform handlers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: REBASE and ports. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic-compiler.cc

diff --git a/src/ic/ic-compiler.cc b/src/ic/ic-compiler.cc

index aeae4ba90e5d0ef6e216e5e34095e8d3e16fca53..4ce9610e708ed5f7cdfa0da601395ad83833f95a 100644

--- a/src/ic/ic-compiler.cc

+++ b/src/ic/ic-compiler.cc

@@ -96,6 +96,9 @@ Handle<Code> PropertyICCompiler::ComputeKeyedLoadMonomorphic(

Handle<Code> stub;

if (receiver_map->has_indexed_interceptor()) {

stub = LoadIndexedInterceptorStub(isolate).GetCode();

+ } else if (receiver_map->IsStringMap()) {

+ // We have a string.

+ stub = LoadIndexedStringStub(isolate).GetCode();

} else if (receiver_map->has_sloppy_arguments_elements()) {

stub = KeyedLoadSloppyArgumentsStub(isolate).GetCode();

} else if (receiver_map->has_fast_elements() ||

« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips/ic-mips.cc » ('j') | no next file with comments »