Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 602593003: Input methods configuration on User Adding Screen should be consistent with signin screen. (Closed)

Created:
6 years, 3 months ago by Alexander Alekseev
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Input methods configuration on User Adding Screen should be consistent with signin screen. This CL adds automatic "last used keyboard layout" for active user POD on User Adding screen. BUG=292774 TEST=manual Committed: https://crrev.com/fac313295f6372c51d227a585e54338077c87191 Cr-Commit-Position: refs/heads/master@{#296557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -10 lines) Patch
M chrome/browser/chromeos/login/ui/user_adding_screen.cc View 3 chunks +4 lines, -1 line 0 comments Download
A chrome/browser/chromeos/login/ui/user_adding_screen_input_methods_controller.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/user_adding_screen_input_methods_controller.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexander Alekseev
Please review.
6 years, 3 months ago (2014-09-24 18:14:43 UTC) #2
dzhioev (left Google)
On 2014/09/24 18:14:43, Alexander Alekseev wrote: > Please review. LGTM
6 years, 3 months ago (2014-09-24 19:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602593003/1
6 years, 3 months ago (2014-09-24 19:16:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b001369cfae8df499c0a2a719425f00081e24ba7
6 years, 2 months ago (2014-09-24 23:29:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 23:46:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac313295f6372c51d227a585e54338077c87191
Cr-Commit-Position: refs/heads/master@{#296557}

Powered by Google App Engine
This is Rietveld 408576698