chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc - Issue 602593003: Input methods configuration on User Adding Screen should be consistent with signin screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 602593003: Input methods configuration on User Adding Screen should be consistent with signin screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/user_adding_screen_input_methods_controller.cc ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

index ebeeafe5c6670aa6d8f7b7f29587b73fad4ed7de..170926075459974747cd534bad7b9b3a7d8c28ef 100644

--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

@@ -1030,15 +1030,6 @@ bool SigninScreenHandler::ShouldLoadGaia() const {

void SigninScreenHandler::SetUserInputMethod(

const std::string& username,

input_method::InputMethodManager::State* ime_state) {

- user_manager::UserManager* user_manager = user_manager::UserManager::Get();

- if (user_manager->IsUserLoggedIn()) {

- // We are on sign-in screen inside user session (adding new user to

- // the session or on lock screen), don't switch input methods in this case.

- // TODO(dpolukhin): adding user and sign-in should be consistent

- // crbug.com/292774

- return;

- }

bool succeed = false;

const std::string input_method = GetUserLRUInputMethod(username);