Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issue 602583003: Revert of Use the pinch viewport offset for tap disambiguation. (Closed)

Created:
6 years, 2 months ago by Mads Ager (chromium)
Modified:
6 years, 2 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Use the pinch viewport offset for tap disambiguation. (patchset #3 id:40001 of https://codereview.chromium.org/584893004/) Reason for revert: Makes webkit_unit_tests fail on Android: [ FAILED ] 1 test, listed below: [ FAILED ] WebFrameTest.DisambiguationPopupPinchViewport 1 FAILED TEST C 79.116s Main ******************************************************************************** C 79.116s Main Detailed Logs C 79.116s Main ******************************************************************************** C 79.119s Main [FAIL] WebFrameTest.DisambiguationPopupPinchViewport: C 79.119s Main ../../third_party/WebKit/Source/web/tests/WebFrameTest.cpp:4413: Failure C 79.119s Main Value of: (frame->view()->scrollPosition()).y() C 79.119s Main Actual: 0 C 79.119s Main Expected: (IntPoint(0, 400)).y() C 79.119s Main Which is: 400 C 79.119s Main ../../third_party/WebKit/Source/web/tests/WebFrameTest.cpp:4434: Failure C 79.119s Main Value of: client.triggered() C 79.119s Main Actual: false C 79.119s Main Expected: true C 79.120s Main ******************************************************************************** C 79.120s Main Summary C 79.120s Main ******************************************************************************** C 79.126s Main [==========] 1467 tests ran. C 79.126s Main [ PASSED ] 1466 tests. C 79.126s Main [ FAILED ] 1 test, listed below: C 79.126s Main [ FAILED ] WebFrameTest.DisambiguationPopupPinchViewport C 79.126s Main C 79.126s Main 1 FAILED TEST C 79.127s Main ******************************************************************************** Original issue's description: > Use the pinch viewport offset for tap disambiguation. > > Account for the pinch vieport offset in the touch rectangle calculation > and pass the offset to the client. The client needs the touch rectangle > relative to both the main frame and to the screen. > > This change is part 1 of 2 (part 2 is chromium side change https://codereview.chromium.org/595693002). > > BUG=370470 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182534 TBR=aelias@chromium.org,bokan@chromium.org,jamesr@chromium.org,timav@google.com,timav@chromium.org NOTREECHECKS=true NOTRY=true BUG=370470 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -136 lines) Patch
M Source/core/frame/PinchViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +4 lines, -15 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 7 chunks +10 lines, -77 lines 0 comments Download
D Source/web/tests/data/disambiguation_popup_200_by_800.html View 1 chunk +0 lines, -37 lines 0 comments Download
M public/web/WebViewClient.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
Created Revert of Use the pinch viewport offset for tap disambiguation.
6 years, 2 months ago (2014-09-24 10:25:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602583003/1
6 years, 2 months ago (2014-09-24 10:26:43 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 10:27:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182579

Powered by Google App Engine
This is Rietveld 408576698