Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 595693002: Use the pinch viewport offset for tap disambiguation. (Closed)

Created:
6 years, 3 months ago by Tima Vaisburd
Modified:
6 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use the pinch viewport offset for tap disambiguation. Obtain the inner viewport origin, touch and target rectangles from the Blink relative to the outer viewport. Use the zoom rectangle in the outer viewport coordinates for bitmap generation but the inner viewport coordinates for the calculation of the physical window zoom rect. This change is part 2 of 2 (part 1 is Blink side change https://codereview.chromium.org/584893004). BUG=370470 Committed: https://crrev.com/29a8d0f6913edc6afb99d1dda3f3f35eb96b8c0a Cr-Commit-Position: refs/heads/master@{#296786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
timav
Part 2: chromium.
6 years, 3 months ago (2014-09-22 23:49:55 UTC) #2
aelias_OOO_until_Jul13
lgtm, adding jamesr@ for content/renderer OWNERS. (BTW James, I do intend to move this away ...
6 years, 3 months ago (2014-09-23 23:19:59 UTC) #4
jamesr
lgtm
6 years, 3 months ago (2014-09-23 23:26:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595693002/1
6 years, 2 months ago (2014-09-25 20:40:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 58f385969a865d34ae1f3ce67398619e7009bcca
6 years, 2 months ago (2014-09-25 20:46:02 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 20:47:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29a8d0f6913edc6afb99d1dda3f3f35eb96b8c0a
Cr-Commit-Position: refs/heads/master@{#296786}

Powered by Google App Engine
This is Rietveld 408576698