Index: chrome/tools/build/win/create_installer_archive.py |
diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py |
index db3a70c5dfef0110664803237ffee20c94d3a33f..5d65197c030d95dbbb0527ed2156782be3319309 100755 |
--- a/chrome/tools/build/win/create_installer_archive.py |
+++ b/chrome/tools/build/win/create_installer_archive.py |
@@ -458,13 +458,16 @@ def DoComponentBuildTasks(staging_dir, build_dir, target_arch, current_version): |
if os.path.basename(component_dll).startswith('remoting_'): |
continue |
# Copy them to the version_dir (for the version assembly to be able to refer |
- # to them below and thus for chrome.exe to be able to load them at runtime). |
+ # to them below and make sure chrome.exe can find them at runtime). |
shutil.copy(component_dll, version_dir) |
# Also copy them directly to the Installer directory for the installed |
# setup.exe to be able to run (as it doesn't statically link in component |
# DLLs). |
- # TODO(gab): This makes the archive ~278MB instead of ~185MB; consider |
- # copying the DLLs over from the installer. |
+ # This makes the archive ~1.5X bigger (Release ~185MB => ~278MB; |
grt (UTC plus 2)
2013/11/15 17:27:53
I agree that this is a sound decision.
|
+ # Debug ~520MB => ~875MB) this is however simpler than any other installer |
+ # change and doesn't make archive generation itself slower so it only |
+ # matters when copying the archive to other test machines. This approach |
+ # can be revised if this is a problem. |
shutil.copy(component_dll, installer_dir) |
component_dll_filenames.append(os.path.basename(component_dll)) |