Clarify comments in create_installer_archive.py.

chrome/tools/build/win/create_installer_archive.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to create Chrome Installer archive.
 
   This script is used to create an archive of all the files required for a
   Chrome install in appropriate directory structure. It reads chrome.release
   file as input, creates chrome.7z archive, compresses setup.exe and
@@ skipping 440 matching lines @@
                               glob.glob(os.path.join(version_dir, '*.dll'))]
   component_dll_filenames = []
   for component_dll in [dll for dll in build_dlls if \
                             os.path.basename(dll) not in staged_dll_basenames]:
     # remoting_*.dll's don't belong in the archive (it doesn't depend on them
     # in gyp). Trying to copy them causes a build race when creating the
     # installer archive in component mode. See: crbug.com/180996
     if os.path.basename(component_dll).startswith('remoting_'):
       continue
     # Copy them to the version_dir (for the version assembly to be able to refer
-    # to them below and thus for chrome.exe to be able to load them at runtime).
+    # to them below and make sure chrome.exe can find them at runtime).
     shutil.copy(component_dll, version_dir)
     # Also copy them directly to the Installer directory for the installed
     # setup.exe to be able to run (as it doesn't statically link in component
     # DLLs).
-    # TODO(gab): This makes the archive ~278MB instead of ~185MB; consider
-    # copying the DLLs over from the installer.
+    # This makes the archive ~1.5X bigger (Release ~185MB => ~278MB;

[grt (UTC plus 2), 2013/11/15 17:27:53]

I agree that this is a sound decision.

+    # Debug ~520MB => ~875MB) this is however simpler than any other installer
+    # change and doesn't make archive generation itself slower so it only
+    # matters when copying the archive to other test machines. This approach
+    # can be revised if this is a problem.
     shutil.copy(component_dll, installer_dir)
     component_dll_filenames.append(os.path.basename(component_dll))
 
   # Copy chrome.exe.manifest as-is. It is required, among other things, to
   # declare a dependency on the version dir assembly.
   shutil.copy(os.path.join(build_dir, 'chrome.exe.manifest'), chrome_dir)
 
   # Also copy setup.exe.manifest as-is. It is required, among other things, to
   # let setup.exe UAC when it wants to, by specifying that it handles elevation
   # "asInvoker", rather than have Windows auto-elevate it when launched.
@@ skipping 125 matching lines @@
   if not options.resource_file_path:
     options.resource_file_path = os.path.join(options.build_dir,
                                               MINI_INSTALLER_INPUT_FILE)
 
   return options
 
 
 if '__main__' == __name__:
   print sys.argv
   sys.exit(main(_ParseOptions()))