Clarify comments in create_installer_archive.py.

Clarify comments in create_installer_archive.py.

This is a follow-up to https://codereview.chromium.org/63153013/

NOTRY=True
BUG=318950, 246169
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235812

[gab, 2013-11-15 16:49:54]

Sir, after looking into this some more this morning, I think copying the DLLs
twice in the archive is the simplest approach.

It would be tricky to add logic to install_worker.cc for the installer to do
this copy at install time (since CopyWorkItem doesn't support wildcards, nor is
AddInstallerCopyTasks() aware of the relevant directories).

This only makes the archive ~1.5X bigger and it doesn't seem to be slower to
generate... so it's really only a minor issue when copying it to VMs, etc. We
can revisit if this really gets in the way IMO... no need for premature
optimization.

PTAL at this and the dcommitted CL as well; I'll update this CL to also reflect
changes you may want to the other CL.

Cheers,
Gab

[grt (UTC plus 2), 2013-11-15 17:27:53]

LGTM

https://codereview.chromium.org/60233008/diff/1/chrome/tools/build/win/create...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/60233008/diff/1/chrome/tools/build/win/create...
chrome/tools/build/win/create_installer_archive.py:466: # This makes the archive
~1.5X bigger (Release ~185MB => ~278MB;
I agree that this is a sound decision.

[grt (UTC plus 2), 2013-11-15 17:29:29]

Please change the CL description to something more like:

Clarify comments in create_installer_archive.py.

BUG=318950

Thanks!

[commit-bot: I haz the power, 2013-11-18 20:44:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/60233008/80001

[commit-bot: I haz the power, 2013-11-18 20:49:16]

Change committed as 235812