Chromium Code Reviews Chromium Code Reviews
Issue
60233004:
Revert 232959 "[Telemetry] Fix image_decoding_measurement timeout." (Closed)
DescriptionRevert 232959 "[Telemetry] Fix image_decoding_measurement timeout."
(Likely) caused timeouts in webgl_conformance_tests on Win and Mac Debug GPU bots.
See Issue 314375 for more details.
> [Telemetry] Fix image_decoding_measurement timeout.
>
> util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate.
>
> Since DispatchNotifications blocks in recv until it gets some data, there is no
> need to poll at an interval. Instead, we should call recv again as soon as
> possible after dispatching a notification.
>
> In the case of the image decoding measurement, it runs timeline recording. There
> were so many timeline messages to receive that we were not always getting to the
> important Page.navigate message before timing out.
>
> Example:
> http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098
>
> BUG=314375
>
> Review URL: https://codereview.chromium.org/47013004
TBR=tonyg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233021
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
