Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 602283002: Adding histograms missing from a previous commit (Closed)

Created:
6 years, 2 months ago by MAD
Modified:
6 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding histograms missing from a previous commit Committed: https://crrev.com/85617878c1beb1069d5b782df040b5a1d3ae045a Cr-Commit-Position: refs/heads/master@{#296995}

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
MAD
Extracted from: https://codereview.chromium.org/607573002/ Which was adding these histogram names for: https://codereview.chromium.org/599653002/ Thanks! BYE MAD ...
6 years, 2 months ago (2014-09-26 00:30:16 UTC) #2
Alexei Svitkine (slow)
lgtm with nit, thanks! https://codereview.chromium.org/602283002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/602283002/diff/1/tools/metrics/histograms/histograms.xml#newcode32722 tools/metrics/histograms/histograms.xml:32722: + so we can identify ...
6 years, 2 months ago (2014-09-26 13:31:01 UTC) #4
MAD
Thanks... Fixed, and landing... https://codereview.chromium.org/602283002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/602283002/diff/1/tools/metrics/histograms/histograms.xml#newcode32722 tools/metrics/histograms/histograms.xml:32722: + so we can identify ...
6 years, 2 months ago (2014-09-26 14:40:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602283002/20001
6 years, 2 months ago (2014-09-26 17:19:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5cda8874be28fe6995bf3d1d540912802f14c03e
6 years, 2 months ago (2014-09-26 19:03:17 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:03:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85617878c1beb1069d5b782df040b5a1d3ae045a
Cr-Commit-Position: refs/heads/master@{#296995}

Powered by Google App Engine
This is Rietveld 408576698