Chromium Code Reviews Chromium Code Reviews
Issue 602283002:
Adding histograms missing from a previous commit (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index f25a4dcd6a95c3a1d179c4a9c3b1e8648798c2a7..6d4d503549e1184ef75a1efdfc53e609b0ea9f69 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -32705,6 +32705,30 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="SoftwareReporter.MajorVersion"> |
| + <owner>mad@chromium.org</owner> |
| + <summary> |
| + As SoftwareReporter.MinorVersion, but a double word combination of the other |
| + components of the version of the software reporter. The high word is the |
| + first component when there are more than one, and the low word is either the |
| + second or third one, depending if there are at least 3, or 4 components. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="SoftwareReporter.MinorVersion"> |
| + <owner>mad@chromium.org</owner> |
| + <summary> |
| + The last component of the version of the software reporter that was executed |
| + so we can identify when user are not getting their component updated as |
|
Alexei Svitkine (slow)
2014/09/26 13:31:01
Nit: "user are" -> "users are"
MAD
2014/09/26 14:40:11
Done.
|
| + quickly as we expect it. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="SoftwareReporter.PromptUsage" enum="SRTPromptUsage"> |
| + <owner>mad@chromium.org</owner> |
| + <summary>Usage of the Software Removal Tool (SRT) Prompt.</summary> |
| +</histogram> |
| + |
| <histogram name="SoftwareReporter.Step" enum="SwReporterStep"> |
| <owner>mad@chromium.org</owner> |
| <summary> |
| @@ -51108,6 +51132,12 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="5" label="DEPRECATION_RAZE_FAILED">Raze failed.</int> |
| </enum> |
| +<enum name="SRTPromptUsage" type="int"> |
| + <int value="0" label="Shown"/> |
| + <int value="1" label="Accepted"/> |
| + <int value="2" label="Denied"/> |
| +</enum> |
| + |
| <enum name="SSLCaptivePortal" type="int"> |
| <int value="0" |
| label="Chrome captive portal detection enabled |
