Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 602253002: Use pub_semver package in pub. (Closed)

Created:
6 years, 2 months ago by Bob Nystrom
Modified:
6 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2034 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/cached_package.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/cache_add.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/global_activate.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/global_packages.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/lock_file.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/package.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/preprocess.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/pubspec.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/solve_report.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 3 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/dependency.dart View 1 chunk +2 lines, -1 line 0 comments Download
D sdk/lib/_internal/pub/lib/src/version.dart View 1 chunk +0 lines, -592 lines 0 comments Download
M sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/implicit_dependency_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lock_file_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/preprocess_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve_packages.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/version_solver_test.dart View 2 chunks +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub/test/version_test.dart View 1 chunk +0 lines, -558 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/cached_package.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/command/cache_add.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/command/global_activate.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/global_packages.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/lock_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/package.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/preprocess.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/pubspec.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/solver/backtracking_solver.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/solver/solve_report.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/solver/version_solver.dart View 3 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/source/hosted.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub_generated/lib/src/version.dart View 1 chunk +0 lines, -341 lines 0 comments Download
M sdk/lib/_internal/pub_generated/test/implicit_barback_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/implicit_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/lock_file_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/preprocess_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/serve_packages.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/test_pub.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/version_solver_test.dart View 2 chunks +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub_generated/test/version_test.dart View 1 chunk +0 lines, -489 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
The one missing piece is a separate patch to vendor in the package once it's ...
6 years, 2 months ago (2014-09-25 22:30:41 UTC) #2
nweiz
lgtm, although obviously don't commit this until the GitHub package exists and is vendored in.
6 years, 2 months ago (2014-09-25 23:02:23 UTC) #3
Bob Nystrom
6 years, 2 months ago (2014-10-01 17:57:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698