Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading dat…

Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading data URLs via NavigationController::LoadURLWithParams.

Tests will follow shortly in the patch that adds webview.loadDataWithBaseURL.

BUG=417816
TBR=rockot@chromium.org

Committed: https://crrev.com/0713c99452dfbfad3b72e7d17c132b78f1c6b9ec
Cr-Commit-Position: refs/heads/master@{#296938}

[paulmeyer, 2014-09-25 19:29:06]

paulmeyer@chromium.org changed reviewers:
+ fsamuel@chromium.org

[paulmeyer, 2014-09-25 19:29:33]

+fsamuel@ for potentially everything

[Fady Samuel, 2014-09-25 20:09:04]

https://codereview.chromium.org/602193002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/web_view/web_view_constants.cc (right):

https://codereview.chromium.org/602193002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/web_view/web_view_constants.cc:90: const char
kInternalBaseURLForDataURL[] = "baseURLForDataURL";
s/URL/Url/gc preferred javascript style.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/web_view.js (right):

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:292: */
Just remove this comment. We don't use this style in chrome.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:296: if (this.baseURLForDataURL != '')
{
s/URL/Url preferred in Javascript.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:306: */
Just remove this comment. we don't use this style in chrome.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:310: if (this.baseURLForDataURL != '')
{
s/URL/Url preferred in Javascript.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/web_view_events.js (right):

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view_events.js:300:
showWarningMessqage(event.reason);
What happened here?

[paulmeyer, 2014-09-25 20:39:51]

ptal

https://codereview.chromium.org/602193002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/web_view/web_view_constants.cc (right):

https://codereview.chromium.org/602193002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/web_view/web_view_constants.cc:90: const char
kInternalBaseURLForDataURL[] = "baseURLForDataURL";
On 2014/09/25 20:09:03, Fady Samuel wrote:
> s/URL/Url/gc preferred javascript style.

Done.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/web_view.js (right):

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:292: */
On 2014/09/25 20:09:03, Fady Samuel wrote:
> Just remove this comment. We don't use this style in chrome.

Done.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:296: if (this.baseURLForDataURL != '')
{
On 2014/09/25 20:09:03, Fady Samuel wrote:
> s/URL/Url preferred in Javascript.

Done.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:306: */
On 2014/09/25 20:09:03, Fady Samuel wrote:
> Just remove this comment. we don't use this style in chrome.

Done.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view.js:310: if (this.baseURLForDataURL != '')
{
On 2014/09/25 20:09:03, Fady Samuel wrote:
> s/URL/Url preferred in Javascript.

Done.

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/web_view_events.js (right):

https://codereview.chromium.org/602193002/diff/1/extensions/renderer/resource...
extensions/renderer/resources/web_view_events.js:300:
showWarningMessqage(event.reason);
Looks like a misguided 'q' got inserted here. My guess is that my cursor
happened to be here and I tried a Ctrl+Q but the Ctrl didn't register or
something like that.

Fixed.
On 2014/09/25 20:09:03, Fady Samuel wrote:
> What happened here?

[paulmeyer, 2014-09-25 20:41:59]

Patchset #2 (id:20001) has been deleted

[Fady Samuel, 2014-09-25 23:05:07]

lgtm

[paulmeyer, 2014-09-26 13:57:35]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-09-26 13:58:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602193002/40001

[commit-bot: I haz the power, 2014-09-26 14:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 14:05:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[paulmeyer, 2014-09-26 14:27:32]

paulmeyer@chromium.org changed reviewers:
+ rockot@chromium.org

[paulmeyer, 2014-09-26 14:29:56]

+rockot@ for OWNER on web_view.js and web_view_events.js. Fady already reviewed,
but the OWNERS hasn't been updated since those files moved. He'll be added in
upcoming patch.

[paulmeyer, 2014-09-26 14:30:09]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-09-26 14:31:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602193002/40001

[commit-bot: I haz the power, 2014-09-26 15:00:40]

Committed patchset #2 (id:40001) as 90a88d12772b916cf5cfe0dffc06882a39486bbb

[commit-bot: I haz the power, 2014-09-26 15:01:41]

Patchset 2 (id:??) landed as
https://crrev.com/0713c99452dfbfad3b72e7d17c132b78f1c6b9ec
Cr-Commit-Position: refs/heads/master@{#296938}