extensions/browser/guest_view/web_view/web_view_guest.cc - Issue 602193002: Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading dat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 602193002: Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading dat… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/web_view/web_view_guest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc

index b68e37f2bb4f845d37874304cea97f80203cea8a..bb24c5db3c99ef51ad23e50ed925d8201a6b2475 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc

@@ -661,6 +661,12 @@ void WebViewGuest::DidCommitProvisionalLoadForFrame(

scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());

args->SetString(guestview::kUrl, url.spec());

args->SetBoolean(guestview::kIsTopLevel, !render_frame_host->GetParent());

+ args->SetString(webview::kInternalBaseURLForDataURL,

+ web_contents()

+ ->GetController()

+ .GetLastCommittedEntry()

+ ->GetBaseURLForDataURL()

+ .spec());

args->SetInteger(webview::kInternalCurrentEntryIndex,

web_contents()->GetController().GetCurrentEntryIndex());

args->SetInteger(webview::kInternalEntryCount,

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_constants.cc ('k') | extensions/renderer/resources/web_view.js » ('j') | no next file with comments »