Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 602043002: FileSystem: Make SandboxDirectoryDatabase::DestroyDatabase non-static for cleanup (Closed)

Created:
6 years, 2 months ago by nhiroki
Modified:
6 years, 2 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, tzik
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

FileSystem: Make SandboxDirectoryDatabase::DestroyDatabase non-static for cleanup There is no behavioral change (just a refactoring). BUG=326429 TEST=content_unittests --gtest_filter=ObfuscatedFileUtilTest.* Committed: https://crrev.com/da4e65e1650cc8c99af2862209f36eb88581fd7d Cr-Commit-Position: refs/heads/master@{#296682}

Patch Set 1 #

Patch Set 2 : remake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M storage/browser/fileapi/obfuscated_file_util.cc View 1 1 chunk +4 lines, -11 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
nhiroki
Hi, can you review this? I'd like to clean up around SandboxDirectoryDatabase and ObfuscatedFileUtil before ...
6 years, 2 months ago (2014-09-25 07:57:21 UTC) #2
nhiroki
As per offline chat with tzik@, I realized that we shouldn't use ScopedPtrHashMap here since ...
6 years, 2 months ago (2014-09-25 08:09:10 UTC) #3
nhiroki
Remade. Can you take another look? Thanks!
6 years, 2 months ago (2014-09-25 08:18:55 UTC) #4
tzik
lgtm
6 years, 2 months ago (2014-09-25 08:25:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602043002/20001
6 years, 2 months ago (2014-09-25 08:48:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c2bca9cc10851e14a61b824b31b14192ca60a56a
6 years, 2 months ago (2014-09-25 09:13:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 09:14:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da4e65e1650cc8c99af2862209f36eb88581fd7d
Cr-Commit-Position: refs/heads/master@{#296682}

Powered by Google App Engine
This is Rietveld 408576698