Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 601753003: ui: Fix the test names for ui/aura and ui/base. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui: Fix the test names for ui/aura and ui/base. Brett prefers we go with foo_unittests, it makes Windows users life easier. And others easier, so they don't need to know/remember the other possibility: /path/to:unittests BUG=None TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug aura_unittests ui_unittests R=brettw@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/a0fd0993f9b64b09e2e2c9cc1c535bb006948394 Cr-Commit-Position: refs/heads/master@{#297128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
6 years, 3 months ago (2014-09-24 13:11:10 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-24 18:58:46 UTC) #2
tfarina
TBRing sky for this...
6 years, 2 months ago (2014-09-28 19:06:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601753003/1
6 years, 2 months ago (2014-09-28 19:08:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as c4a182ef33eb63f922981bd8a66b718e25969e18
6 years, 2 months ago (2014-09-28 19:11:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as c4a182ef33eb63f922981bd8a66b718e25969e18
6 years, 2 months ago (2014-09-28 19:11:42 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-28 19:12:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0fd0993f9b64b09e2e2c9cc1c535bb006948394
Cr-Commit-Position: refs/heads/master@{#297128}

Powered by Google App Engine
This is Rietveld 408576698