Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: ui/base/BUILD.gn

Issue 601753003: ui: Fix the test names for ui/aura and ui/base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 0436bec3a2df2aac38e5aee21380289a7d9c9b13..bde23209b42267f1a768a746a1d97b9cdf23133d 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -698,15 +698,14 @@ if (is_android) {
# TODO(GYP): Make this work on Android and reenable it.
if (!is_android) {
+# TODO(tfarina): Rename this target to ui_base_unittests.
+# In order to do this we will need to keep this target, add a dummy
+# ui_base_unittests target that just points to ui_unittests, change
+# buildbot code to reference the new 'ui_base_unittests' target.
+# After buildbot is updated, we can make the changes in Chromium and
+# remove 'ui_unittests' target. crbug.com/331829
# GYP version: ui/base/ui_base_tests.gyp:ui_unittests
-test("unittests") {
- # TODO(tfarina): Rename this target to ui_base_unittests.
- # In order to do this we will need to keep this target, add a dummy
- # ui_base_unittests target that just points to ui_unittests, change
- # buildbot code to reference the new 'ui_base_unittests' target.
- # After buildbot is updated, we can make the changes in Chromium and
- # remove 'ui_unittests' target. crbug.com/331829
- output_name = "ui_unittests"
+test("ui_unittests") {
sources = [
"l10n/l10n_util_mac_unittest.mm",
"l10n/l10n_util_unittest.cc",
« no previous file with comments | « ui/aura/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698