Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 601623002: Move paint code from RenderMultiColumnSet to MultiColumnSetPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Move paint code from RenderMultiColumnSet to MultiColumnSetPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182618

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -73 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/paint/MultiColumnSetPainter.h View 1 chunk +27 lines, -0 lines 0 comments Download
A Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +88 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 2 chunks +2 lines, -68 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chrishtr
6 years, 2 months ago (2014-09-24 00:42:45 UTC) #2
pdr.
On 2014/09/24 00:42:45, chrishtr wrote: LGTM
6 years, 2 months ago (2014-09-24 00:54:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601623002/1
6 years, 2 months ago (2014-09-24 00:55:50 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-09-24 02:00:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601623002/20001
6 years, 2 months ago (2014-09-24 16:27:41 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 17:40:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182618

Powered by Google App Engine
This is Rietveld 408576698