Chromium Code Reviews
Help | Chromium Project | Sign in
(356)

Issue 6016001: Fix nits. Add 'const'. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
akalin
CC:
chromium-reviews_chromium.org, Raghu Simha, ncarter, pam+watch_chromium.org, timsteele, idana
Visibility:
Public.

Description

Fix nits. Add 'const'.

R=akalin
BUG=63357, 67239
TEST=no compliation errors.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70445

Patch Set 1 #

Patch Set 2 : Forgot to save the files before upload #

Total comments: 2

Patch Set 3 : Don't make accessors const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Lint Patch
M chrome/browser/sync/tools/sync_listen_notifications.cc View 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M jingle/notifier/base/chrome_async_socket.h View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M jingle/notifier/communicator/login_settings.h View 2 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
wtc
These are the changes agl suggested in http://codereview.chromium.org/5958001/. Do you want me to make class ...
3 years, 4 months ago #1
akalin
everything else LGTM http://codereview.chromium.org/6016001/diff/5001/jingle/notifier/communicator/login_settings.h File jingle/notifier/communicator/login_settings.h (right): http://codereview.chromium.org/6016001/diff/5001/jingle/notifier/communicator/login_settings.h#newcode46 jingle/notifier/communicator/login_settings.h:46: net::HostResolver* host_resolver() const { i don't ...
3 years, 3 months ago #2
wtc
3 years, 3 months ago #3
Thanks for the review.

http://codereview.chromium.org/6016001/diff/5001/jingle/notifier/communicator...
File jingle/notifier/communicator/login_settings.h (right):

http://codereview.chromium.org/6016001/diff/5001/jingle/notifier/communicator...
jingle/notifier/communicator/login_settings.h:46: net::HostResolver*
host_resolver() const {
On 2010/12/20 23:11:42, akalin wrote:
> i don't think it makes sense for accessors of pointer members to be const
unless
> it already returns a pointer-to-const, since you can modify the object anyway.

I know people have different opinions on this issue.
I committed the CL without these changes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434