Issue 6016001: Fix nits. Add 'const'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6016001: Fix nits. Add 'const'. (Closed)

Created:
10 years ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), pam+watch_chromium.org, tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix nits. Add 'const'. R=akalin BUG=63357, 67239 TEST=no compliation errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70445

Patch Set 2 : Forgot to save the files before upload #

Total comments: 2

Patch Set 3 : Don't make accessors const #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	jingle/notifier/base/chrome_async_socket.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	jingle/notifier/communicator/login_settings.h	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

These are the changes agl suggested in http://codereview.chromium.org/5958001/. Do you want me to make class ...

10 years ago (2010-12-17 17:04:21 UTC) #1

akalin

everything else LGTM http://codereview.chromium.org/6016001/diff/5001/jingle/notifier/communicator/login_settings.h File jingle/notifier/communicator/login_settings.h (right): http://codereview.chromium.org/6016001/diff/5001/jingle/notifier/communicator/login_settings.h#newcode46 jingle/notifier/communicator/login_settings.h:46: net::HostResolver* host_resolver() const { i don't ...

10 years ago (2010-12-20 23:11:42 UTC) #2