Fix nits. Add 'const'.

jingle/notifier/communicator/login_settings.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef JINGLE_NOTIFIER_COMMUNICATOR_LOGIN_SETTINGS_H_
 #define JINGLE_NOTIFIER_COMMUNICATOR_LOGIN_SETTINGS_H_
 #include <string>
 
 #include "jingle/notifier/communicator/xmpp_connection_generator.h"
 #include "talk/base/scoped_ptr.h"
@@ skipping 25 matching lines @@
                 ServerInformation* server_list,
                 int server_count,
                 bool try_ssltcp_first);
 
   ~LoginSettings();
 
   bool try_ssltcp_first() const {
     return try_ssltcp_first_;
   }
 
-  net::HostResolver* host_resolver() {
+  net::HostResolver* host_resolver() const {

[akalin, 2010/12/20 23:11:42]

i don't think it makes sense for accessors of pointer members to be const unless
it already returns a pointer-to-const, since you can modify the object anyway.

[wtc, 2011/01/04 21:23:53]

I know people have different opinions on this issue.
I committed the CL without these changes.

     return host_resolver_;
   }
 
-  net::CertVerifier* cert_verifier() {
+  net::CertVerifier* cert_verifier() const {
     return cert_verifier_;
   }
 
   const ServerInformation* server_list() const {
     return server_override_.get() ? server_override_.get() : server_list_.get();
   }
 
   int server_count() const {
     return server_override_.get() ? 1 : server_count_;
   }
 
   const buzz::XmppClientSettings& user_settings() const {
     return *user_settings_.get();
   }
 
   buzz::XmppClientSettings* modifiable_user_settings() {
     return user_settings_.get();
   }
 
   const ConnectionOptions& connection_options() const {
     return *connection_options_.get();
   }
 
   void set_server_override(const net::HostPortPair& server);
   void clear_server_override();
 
  private:
   bool try_ssltcp_first_;
 
-  net::HostResolver* host_resolver_;
-  net::CertVerifier* cert_verifier_;
+  net::HostResolver* const host_resolver_;
+  net::CertVerifier* const cert_verifier_;
   talk_base::scoped_array<ServerInformation> server_list_;
   int server_count_;
   // Used to handle redirects
   scoped_ptr<ServerInformation> server_override_;
 
   scoped_ptr<buzz::XmppClientSettings> user_settings_;
   scoped_ptr<ConnectionOptions> connection_options_;
   DISALLOW_COPY_AND_ASSIGN(LoginSettings);
 };
 }  // namespace notifier
 #endif  // JINGLE_NOTIFIER_COMMUNICATOR_LOGIN_SETTINGS_H_