Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 601563002: Remove IPC::Channel::TakePipeHandle() (Closed)

Created:
6 years, 3 months ago by Hajime Morrita
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove IPC::Channel::TakePipeHandle() It doesn't work, and it is no longer used. BUG=416208 R=cpu@chromium.org, jam@chromium.org Committed: https://crrev.com/cfdd7ba3cf8658df5a5484b716a1dc48ce3e0674 Cr-Commit-Position: refs/heads/master@{#296820}

Patch Set 1 #

Patch Set 2 : Fixed Nacl build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M ipc/ipc_channel.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_test_sink.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Hajime Morrita
6 years, 3 months ago (2014-09-23 21:42:53 UTC) #1
Hajime Morrita
Fixed Nacl build error
6 years, 3 months ago (2014-09-23 22:40:52 UTC) #2
Hajime Morrita
Carlos: Ping. This is just a removal of an unused, dangerous function. All bots are ...
6 years, 3 months ago (2014-09-24 19:47:43 UTC) #3
Hajime Morrita
cpu: Ping? pure removal.
6 years, 2 months ago (2014-09-25 22:21:42 UTC) #4
darin (slow to review)
I love pure code removals. LGTM!
6 years, 2 months ago (2014-09-25 22:46:29 UTC) #6
cpu_(ooo_6.6-7.5)
thanks for doing this! lgtm
6 years, 2 months ago (2014-09-25 23:00:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601563002/20001
6 years, 2 months ago (2014-09-25 23:06:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9713a94aa11b9e090a284f6d7bd444c1d995d193
6 years, 2 months ago (2014-09-25 23:12:25 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:13:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cfdd7ba3cf8658df5a5484b716a1dc48ce3e0674
Cr-Commit-Position: refs/heads/master@{#296820}

Powered by Google App Engine
This is Rietveld 408576698