ipc/ipc_channel_nacl.cc - Issue 601563002: Remove IPC::Channel::TakePipeHandle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_nacl.cc

Issue 601563002: Remove IPC::Channel::TakePipeHandle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Nacl build error Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_nacl.cc

diff --git a/ipc/ipc_channel_nacl.cc b/ipc/ipc_channel_nacl.cc

index 704f7d88d4267023e18af0f7c5d71e57405198cb..efac7fb711d92687013332bc1c9838118560160e 100644

--- a/ipc/ipc_channel_nacl.cc

+++ b/ipc/ipc_channel_nacl.cc

@@ -149,11 +149,6 @@ base::ProcessId ChannelNacl::GetSelfPID() const {

return -1;

}

-ChannelHandle ChannelNacl::TakePipeHandle() {

- // NACL doesn't have any platform-level handles.

- return ChannelHandle();

bool ChannelNacl::Connect() {

if (pipe_ == -1) {

DLOG(WARNING) << "Channel creation failed: " << pipe_name_;

« no previous file with comments | « ipc/ipc_channel_nacl.h ('k') | ipc/ipc_channel_posix.h » ('j') | no next file with comments »