Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 601523003: Network error interstitial bug fixes (Closed)

Created:
6 years, 3 months ago by edwardjung
Modified:
6 years, 2 months ago
CC:
chromium-reviews, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

+ Prevent flash of blue buttons before page content is populated + Correct the layout and size of the offline icon when getting a DNS_PROBE_FINISHED_NO_INTERNET error + Delay AudioContext initialising until required to reduce CPU usage. BUG=417614 Committed: https://crrev.com/d0956cf3b7e8662b94e3ef26b4d685ddc6702a0a Cr-Commit-Position: refs/heads/master@{#296801}

Patch Set 1 #

Patch Set 2 : Fix blue button flash when page loads #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M chrome/common/localized_error.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/resources/neterror.css View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 1 2 chunks +18 lines, -11 lines 0 comments Download
M chrome/renderer/resources/offline.js View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
edwardjung
Lei, some bug fixes to the recently updated network error interstitial page. Thanks.
6 years, 2 months ago (2014-09-25 15:21:22 UTC) #2
Lei Zhang
deferring to arv@
6 years, 2 months ago (2014-09-25 18:16:18 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 2 months ago (2014-09-25 18:30:17 UTC) #5
Lei Zhang
lgtm stamp then
6 years, 2 months ago (2014-09-25 18:33:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601523003/20001
6 years, 2 months ago (2014-09-25 20:04:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c8d0e23739e9c151b638e7bb8557cd19c3f44f82
6 years, 2 months ago (2014-09-25 21:58:36 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 21:59:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0956cf3b7e8662b94e3ef26b4d685ddc6702a0a
Cr-Commit-Position: refs/heads/master@{#296801}

Powered by Google App Engine
This is Rietveld 408576698