ESC accelerator and consistent overview mode for Athena homecard

athena/wm/public/window_manager.h

Index: athena/wm/public/window_manager.h
diff --git a/athena/wm/public/window_manager.h b/athena/wm/public/window_manager.h
index bafc618bfb2f7f27e0b15885849c96eebdbfe5ba..83ed138982551bb52f5d1d61033fa37b72294210 100644
--- a/athena/wm/public/window_manager.h
+++ b/athena/wm/public/window_manager.h
@@ -24,7 +24,7 @@ class ATHENA_EXPORT WindowManager {
   virtual ~WindowManager() {}
 
   virtual void ToggleOverview() = 0;

[Jun Mukai, 2014/10/03 02:26:06]

Can you remove ToggleOverview?
It can be simply rewritten as SetInOverview(!IsOverviewModeActive())

[Greg Levin, 2014/10/06 20:28:00]

Done.

-
+  virtual void ActivateOverview(bool activate) = 0;

[Jun Mukai, 2014/10/03 02:26:07]

WindowManagerImpl already has SetInOverview(). Why not simply reusing this name?

[Greg Levin, 2014/10/06 20:28:00]

SetInOverview() (private) only deals with internal state. 
ActivateOverview(false) will additionally show the window which was active prior
to overview mode.  Some code is only calling SetInOverview(), and so presumably
doesn't want the previous window shown.  I assume this is why ToggleOverview()
and SetInOverview() were previously separate functions, and so I've left this
separation.

   virtual bool IsOverviewModeActive() = 0;
 
   virtual void AddObserver(WindowManagerObserver* observer) = 0;