ESC accelerator and consistent overview mode for Athena homecard

athena/wm/public/window_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ATHENA_SCREEN_PUBLIC_WINDOW_MANAGER_H_
 #define ATHENA_SCREEN_PUBLIC_WINDOW_MANAGER_H_
 
 #include "athena/athena_export.h"
 
 namespace athena {
 
 class WindowListProvider;
 class WindowManagerObserver;
 
 // Manages the application, web windows.
 class ATHENA_EXPORT WindowManager {
  public:
   // Creates and deletes the singleton object of the WindowManager
   // implementation.
   static WindowManager* Create();
   static void Shutdown();
   static WindowManager* Get();
 
   virtual ~WindowManager() {}
 
   virtual void ToggleOverview() = 0;

[Jun Mukai, 2014/10/03 02:26:06]

Can you remove ToggleOverview?
It can be simply rewritten as SetInOverview(!IsOverviewModeActive())

[Greg Levin, 2014/10/06 20:28:00]

Done.

-
+  virtual void ActivateOverview(bool activate) = 0;

[Jun Mukai, 2014/10/03 02:26:07]

WindowManagerImpl already has SetInOverview(). Why not simply reusing this name?

[Greg Levin, 2014/10/06 20:28:00]

SetInOverview() (private) only deals with internal state. 
ActivateOverview(false) will additionally show the window which was active prior
to overview mode.  Some code is only calling SetInOverview(), and so presumably
doesn't want the previous window shown.  I assume this is why ToggleOverview()
and SetInOverview() were previously separate functions, and so I've left this
separation.

   virtual bool IsOverviewModeActive() = 0;
 
   virtual void AddObserver(WindowManagerObserver* observer) = 0;
   virtual void RemoveObserver(WindowManagerObserver* observer) = 0;
 
   virtual void ToggleSplitViewForTest() = 0;
 
   // This returns the window list provider of the current MRU order of windows.
   // The ownership remains with the WindowManager.
   virtual WindowListProvider* GetWindowListProvider() = 0;
 };
 
 }  // namespace athena
 
 #endif  // ATHENA_SCREEN_PUBLIC_WINDOW_MANAGER_H_