[src/content] Apply automatic range checks to enum types across IPC .

[src/content] Apply automatic range checks to enum types across IPC .

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708
Committed: https://crrev.com/bceff726fd2d4bf7d1cb2eec86cec65611dcd785
Cr-Commit-Position: refs/heads/master@{#297221}

[ARUNKK, 2014-09-25 10:19:28]

kulkarni.a@samsung.com changed reviewers:
+ avi@chromium.org, kenrb@chromium.org

[ARUNKK, 2014-09-25 10:19:28]

kenrb@chromium.org: Please review changes in 

avi@chromium.org: Please review changes in 

PTAL.

[Avi (use Gerrit), 2014-09-25 15:39:34]

Please don't let this get to be automatic.

https://codereview.chromium.org/601153002/diff/1/content/common/navigation_ge...
File content/common/navigation_gesture.h (right):

https://codereview.chromium.org/601153002/diff/1/content/common/navigation_ge...
content/common/navigation_gesture.h:20: NAVIGATIONGESTURE_LAST =
NavigationGestureUnknown
Match the style. Adding one MACRO_STYLE item to a CamelCase list is not OK.

https://codereview.chromium.org/601153002/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

https://codereview.chromium.org/601153002/diff/1/content/common/view_messages...
content/common/view_messages.h:84: IPC_ENUM_TRAITS_MAX_VALUE(content::PageZoom,
Please don't do this blindly! PageZoom has a min value of -1, so this line is
wrong.

Do:

IPC_ENUM_TRAITS_MIN_MAX_VALUE(content::PageZoom, PAGE_ZOOM_OUT, PAGE_ZOOM_IN);

Do we need a new max value for this?

[ARUNKK, 2014-09-26 06:08:07]

Review comments are incorporated.
PTAL.

https://codereview.chromium.org/601153002/diff/1/content/common/navigation_ge...
File content/common/navigation_gesture.h (right):

https://codereview.chromium.org/601153002/diff/1/content/common/navigation_ge...
content/common/navigation_gesture.h:20: NAVIGATIONGESTURE_LAST =
NavigationGestureUnknown
On 2014/09/25 15:39:34, Avi wrote:
> Match the style. Adding one MACRO_STYLE item to a CamelCase list is not OK.

Done.

https://codereview.chromium.org/601153002/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

https://codereview.chromium.org/601153002/diff/1/content/common/view_messages...
content/common/view_messages.h:84: IPC_ENUM_TRAITS_MAX_VALUE(content::PageZoom,
On 2014/09/25 15:39:34, Avi wrote:
> Please don't do this blindly! PageZoom has a min value of -1, so this line is
> wrong.
> 
> Do:
> 
> IPC_ENUM_TRAITS_MIN_MAX_VALUE(content::PageZoom, PAGE_ZOOM_OUT, PAGE_ZOOM_IN);
> 
> Do we need a new max value for this?

Done.

[ARUNKK, 2014-09-26 06:23:04]

On 2014/09/26 06:08:07, ARUNKK wrote:
> Review comments are incorporated.
> PTAL.
> 
>
https://codereview.chromium.org/601153002/diff/1/content/common/navigation_ge...
> File content/common/navigation_gesture.h (right):
> 
>
https://codereview.chromium.org/601153002/diff/1/content/common/navigation_ge...
> content/common/navigation_gesture.h:20: NAVIGATIONGESTURE_LAST =
> NavigationGestureUnknown
> On 2014/09/25 15:39:34, Avi wrote:
> > Match the style. Adding one MACRO_STYLE item to a CamelCase list is not OK.
> 
> Done.
> 
>
https://codereview.chromium.org/601153002/diff/1/content/common/view_messages.h
> File content/common/view_messages.h (right):
> 
>
https://codereview.chromium.org/601153002/diff/1/content/common/view_messages...
> content/common/view_messages.h:84:
IPC_ENUM_TRAITS_MAX_VALUE(content::PageZoom,
> On 2014/09/25 15:39:34, Avi wrote:
> > Please don't do this blindly! PageZoom has a min value of -1, so this line
is
> > wrong.
> > 
> > Do:
> > 
> > IPC_ENUM_TRAITS_MIN_MAX_VALUE(content::PageZoom, PAGE_ZOOM_OUT,
PAGE_ZOOM_IN);
> > 
> > Do we need a new max value for this?
> 
> Done.

PTAL.

[Avi (use Gerrit), 2014-09-26 15:07:10]

https://codereview.chromium.org/601153002/diff/60001/content/common/view_mess...
File content/common/view_messages.h (right):

https://codereview.chromium.org/601153002/diff/60001/content/common/view_mess...
content/common/view_messages.h:85: content::PageZoom::PAGE_ZOOM_IN)
1) respect 80 column limit
2) alignment

[ARUNKK, 2014-09-27 08:17:00]

Review comments are incorporated .
PTAL.

[Avi (use Gerrit), 2014-09-29 16:11:20]

LGTM

[kenrb, 2014-09-29 17:11:36]

ipc lgtm

[ARUNKK, 2014-09-29 18:10:27]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-09-29 18:11:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/601153002/100001

[commit-bot: I haz the power, 2014-09-29 19:03:33]

Committed patchset #6 (id:100001) as 82ef1d98d0946a024d1912f31b3a59b16ddb7faf

[commit-bot: I haz the power, 2014-09-29 19:04:19]

Patchset 6 (id:??) landed as
https://crrev.com/bceff726fd2d4bf7d1cb2eec86cec65611dcd785
Cr-Commit-Position: refs/heads/master@{#297221}